Messages in this thread | | | Date | Fri, 2 Sep 2011 15:38:07 +0800 | Subject | Re: [PATCH 3/3] trace points: power: remove 'cpu_id' from trace_cpu_idle | From | Ming Lei <> |
| |
Hi,
On Fri, Sep 2, 2011 at 3:26 PM, Jean Pihet <jean.pihet@newoldbits.com> wrote: >> It was known that cpu_id is always the current cpu with current >> implementation when this got introduced. >> But the perf events API must not change back and forth for userspace >> compatibility. Therefore the cpu_id was added in case >> that future implementations want to pass info where the current cpu >> is not the cpu which is sent to the sleep state. > Agree. Let's keep the cpu_id field.
OK, let's keep it.
How about removing it in clock_enalbe/clock_disable/power_domain_target as did in [1/3] and [2/3]? I don't see any usefulness of 'cpu_id' in the tree trace points.
thanks, -- Ming Lei
| |