lkml.org 
[lkml]   [2011]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v2] Fix EDAC sdram_scrub_rate read/write failure
> @Tony, do you think the above makes sense? Anything against changing
> that part of the EDAC API to say:

> Sdram memory scrubbing rate:

> If configuration fails or memory scrubbing is not implemented,
> the access to that attribute from userspace will fail.

Ideally we'd not have the file there at all if memory scrubbing isn't
implemented.

I like having the write fail if the driver cannot set the chosen
scrub rate ... though there seems to be some wiggle room ... scrub
rates aren't exact, the user can try to set one and then read back
to find out what the rate was actually rounded to. If you have to
read back anyway, then reading back to find out if you failed doesn't
look quite so odd (still odd, but with some sort of logic).

-Tony


\
 
 \ /
  Last update: 2011-09-19 22:25    [W:0.096 / U:2.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site