lkml.org 
[lkml]   [2011]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] Include irq and softirq fields in cpuacct
On 09/19/2011 03:38 PM, Peter Zijlstra wrote:
> On Wed, 2011-09-14 at 17:04 -0300, Glauber Costa wrote:
>> + CPUACCT_STAT_IRQ, /* ... irq ticks */
>> + CPUACCT_STAT_SOFTIRQ, /* ... softirq ticks */
>
> Would it make sense to make the cpustat thing an array as well? That way
> the if forest will compute an array index and the cgroup and cpustat
> parts can then use the 'same' code.
>
> That avoids having to pass a cputime64_t* and int around for pretty much
> the same thing.
I think so, and I go further: I think that when cgroups are compiled in
- by far the common case this days - cpustat should be just cpuacct for
the root cgroup. With the right macro trickery, I can even be quite
transparent...


\
 
 \ /
  Last update: 2011-09-19 20:43    [from the cache]
©2003-2011 Jasper Spaans