lkml.org 
[lkml]   [2011]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH ] dynamic_debug: call __netdev_printk only for CONFIG_NET
    On 09/18/2011 11:27 AM, Greg KH wrote:
    > On Sun, Sep 18, 2011 at 10:21:14AM -0700, Randy Dunlap wrote:
    >> On 09/18/2011 01:27 AM, Greg KH wrote:
    >>> On Thu, Sep 01, 2011 at 11:18:18AM -0400, Jason Baron wrote:
    >>>> On Thu, Sep 01, 2011 at 04:57:02PM +0200, Arnd Bergmann wrote:
    >>>>> __netdev_printk is only defined when CONFIG_NET is set. Since we only need
    >>>>> __dynamic_netdev_dbg for network drivers, we can make it conditional on the
    >>>>> same Kconfig symbol.
    >>>>>
    >>>>
    >>>> Hi,
    >>>>
    >>>> Yes, I've posted a fix for this:
    >>>>
    >>>> https://lkml.org/lkml/2011/8/30/297
    >>>>
    >>>> Hopefully, it will be pulled in soon.
    >>>
    >>> As that thread again spun off into confusion, can you please resend the
    >>> end result?
    >>
    >> That spinning confusion had nothing to do with the posted & correct patch
    >> which could have been applied several weeks ago.
    >>
    >> I'm curious: Do you delete most of your email on a routine basis?
    >
    > No, only after going through pending patches do I purge them. And when
    > a series of patches generates a thread like this one, where people are
    > arguing over the way the macros are named, and no one seems to agree, I
    > will take it as the fact that this series was contentious and needs to
    > be resent after taking into consideration the original complaints.

    Sheesh. The naming of the macros has nothing to do with this build fix.

    > For me to keep all email threads, based on the amount of email I get[1],
    > would be ludicrous.
    >
    > greg k-h
    >
    > [1]: http://www.kroah.com/log/linux/get_lots_of_email.html


    --
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***


    \
     
     \ /
      Last update: 2011-09-18 20:45    [W:0.035 / U:0.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site