lkml.org 
[lkml]   [2011]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/7] BTRFS: Fix lseek return value for error
    Date
    Excerpts from Jeff liu's message of 2011-09-18 06:33:38 -0400:
    >
    > 在 2011-9-18,下午4:42, Marco Stornelli 写道:
    >
    > > Il 18/09/2011 09:29, Jeff Liu ha scritto:
    > >> Hi Andreas and Andi,
    > >>
    > >> Thanks for your comments.
    > >>
    > >> On 09/18/2011 09:46 AM, Andi Kleen wrote:
    > >>
    > >>>>> with an additional improvement if the offset is larger or equal to the
    > >>>>> file size, return -ENXIO in directly:
    > >>>>>
    > >>>>> if (offset>= inode->i_size) {
    > >>>>> mutex_unlock(&inode->i_mutex);
    > >>>>> return -ENXIO;
    > >>>>> }
    > >>>>
    > >>>> Except that is wrong, because it would then be impossible to write sparse files.
    > >>
    > >> Per my tryout, except that, if the offset>= source file size, call
    > >> lseek(fd, offset, SEEK_DATA/SEEK_HOLE) against Btrfs will always return
    > >> the total file size rather than -ENXIO. however, our desired result it
    > >> -ENXIO in this case, Am I right?
    > >>
    > >
    > > Yes, ENXIO should be the operation result.
    >
    > Thanks for your kind confirmation.

    Thanks everyone, I've put Jeff's last version of this in my queue.

    -chris
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-09-18 16:59    [W:0.024 / U:93.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site