lkml.org 
[lkml]   [2011]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/7] BTRFS: Fix lseek return value for error
From
Date

在 2011-9-18,下午4:42, Marco Stornelli 写道:

> Il 18/09/2011 09:29, Jeff Liu ha scritto:
>> Hi Andreas and Andi,
>>
>> Thanks for your comments.
>>
>> On 09/18/2011 09:46 AM, Andi Kleen wrote:
>>
>>>>> with an additional improvement if the offset is larger or equal to the
>>>>> file size, return -ENXIO in directly:
>>>>>
>>>>> if (offset>= inode->i_size) {
>>>>> mutex_unlock(&inode->i_mutex);
>>>>> return -ENXIO;
>>>>> }
>>>>
>>>> Except that is wrong, because it would then be impossible to write sparse files.
>>
>> Per my tryout, except that, if the offset>= source file size, call
>> lseek(fd, offset, SEEK_DATA/SEEK_HOLE) against Btrfs will always return
>> the total file size rather than -ENXIO. however, our desired result it
>> -ENXIO in this case, Am I right?
>>
>
> Yes, ENXIO should be the operation result.

Thanks for your kind confirmation.


-Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-09-18 12:37    [W:1.009 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site