Messages in this thread | | | From | Linus Torvalds <> | Date | Sun, 18 Sep 2011 12:55:06 -0700 | Subject | Re: [GIT] Networking |
| |
On Sun, Sep 18, 2011 at 12:48 PM, Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > > The following works for me:
No it doesn't. It may *compile* for you, but it doesn't work for you. It avoids all the other stuff that tcp_syn_flood_action() also does (notably the printout).
The real fix looks to be either:
- make an empty (inline/macro) cookie_v4_init_sequence() for the non-syncookie config case
OR
- change tcp_syn_flood_action() to have an inline wrapper that always returns 0 for the non-syncookie config case so that the compiler can see statically that when syncookies are disabled, it will always return zero.
Or something like that.
Tssk. David, linux-next may not be fully operational, but by -rc6 you shouldn't have sent me stuff like this that was even *remotely* complex anyway.
Stop it.
Linus
| |