lkml.org 
[lkml]   [2011]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cfs: remove unused 'if' condition checking
On Fri, Sep 16, 2011 at 01:35:52PM -0400, Wang Xingchao wrote:
> nr_running must be more than 1, so remove the checking
>
> Signed-off-by: Wang Xingchao <xingchao.wang@intel.com>

The patch looks good. And comments below.

> ---
> kernel/sched_fair.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index 1ca2cd4..fef0bfd 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -1106,6 +1106,8 @@ static void
> check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr)
> {
> unsigned long ideal_runtime, delta_exec;
> + struct sched_entity *se;
> + s64 delta;
>
> ideal_runtime = sched_slice(cfs_rq, curr);
> delta_exec = curr->sum_exec_runtime - curr->prev_sum_exec_runtime;
> @@ -1127,16 +1129,14 @@ check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr)
> if (delta_exec < sysctl_sched_min_granularity)
> return;
>
> - if (cfs_rq->nr_running > 1) {
> - struct sched_entity *se = __pick_first_entity(cfs_rq);
> - s64 delta = curr->vruntime - se->vruntime;

It's better to add some comments to explain why se could not be NULL.

Thanks,
Yong

> + se = __pick_first_entity(cfs_rq);
> + delta = curr->vruntime - se->vruntime;
>
> - if (delta < 0)
> - return;
> + if (delta < 0)
> + return;
>
> - if (delta > ideal_runtime)
> - resched_task(rq_of(cfs_rq)->curr);
> - }
> + if (delta > ideal_runtime)
> + resched_task(rq_of(cfs_rq)->curr);
> }
>
> static void
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Only stand for myself


\
 
 \ /
  Last update: 2011-09-16 07:57    [W:0.053 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site