Messages in this thread | | | Date | Fri, 16 Sep 2011 14:33:44 +0200 | From | Michal Marek <> | Subject | Re: [PATCH 1/4] kbuild: introduce KBUILD_CONFIG; unexpose KCONFIG_CONFIG |
| |
On 16.9.2011 14:31, Michal Marek wrote: > On 16.8.2011 07:34, Arnaud Lacombe wrote: >> Refine the Kbuild interface to expose it's own variable to architecture >> Makefile's and prepare Kconfig environment prior to any %config invocation. >> >> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com> >> --- >> Makefile | 8 ++++++-- >> arch/arm/boot/compressed/Makefile | 2 +- >> arch/unicore32/boot/compressed/Makefile | 2 +- >> scripts/kconfig/Makefile | 3 +++ >> 4 files changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index b4ca4e1..26798a4 100644 >> --- a/Makefile >> +++ b/Makefile > [...] >> +# Prepare Kconfig environment >> +KCONFIG_CONFIG = $(KBUILD_CONFIG) >> +export KCONFIG_CONFIG > > IMO we should preserve the semantics of KCONFIG_CONFIG as much as > possible. make KCONFIG_CONFIG=blah works, but setting it in the > environment does not, because the '=' assignment take precendence.
Also, please mention KBUILD_CONFIG variable in Documentation/kbuild/kconfig.txt. Or maybe Documentation/kbuild/kbuild.txt, I'm not sure what is the best fit now.
Michal
| |