Messages in this thread | | | Date | Wed, 14 Sep 2011 12:57:12 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH v3 06/11] KVM: MMU: cleanup FNAME(invlpg) |
| |
On 09/13/2011 09:31 PM, Xiao Guangrong wrote: > >> @@ -675,36 +684,20 @@ static void FNAME(invlpg)(struct kvm_vcpu *vcpu, gva_t gva) > >> > >> sp = page_header(__pa(sptep)); > >> if (is_last_spte(*sptep, level)) { > >> - int offset, shift; > >> - > >> if (!sp->unsync) > >> break; > >> > >> - shift = PAGE_SHIFT - > >> - (PT_LEVEL_BITS - PT64_LEVEL_BITS) * level; > >> - offset = sp->role.quadrant<< shift; > >> - > >> - pte_gpa = (sp->gfn<< PAGE_SHIFT) + offset; > >> + pte_gpa = FNAME(get_first_pte_gpa)(sp); > > > > > > Here is can be used for L2 - I think we can use 2MB host pages to back 4MB guest mappings. > > > > Only unsync shadow page is fetched here, and its level is always 1. >
Right.
-- error compiling committee.c: too many arguments to function
| |