lkml.org 
[lkml]   [2011]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Kernel 3.1.0-rc4 oops when connecting iPod
    On Mon, Sep 12, 2011 at 10:20:01PM -0400, Pavel Ivanov wrote:
    > This patch works for me.
    >
    > And could you comment on my PAGE_SIZE question?
    >
    > >> Also I have a little concern about consistency in using
    > >> PAGE_CACHE_SHIFT and PAGE_SHIFT. hfsplus_read_wrapper() limits visible
    > >> block size to PAGE_SIZE, not PAGE_CACHE_SIZE. And although now they
    > >> are equal comment in linux/pagemap.h clearly says that PAGE_CACHE_SIZE
    > >> can be bigger than PAGE_SIZE. Is it something that should be fixed in
    > >> hfsplus_read_wrapper() ?

    The two are and always have been the same. There were plans to allow
    for a larger PAGE_CACHE_SIZE long time ago, but it never happened.

    I'll switch everything to PAGE_SIZE in the patch for consistency.


    \
     
     \ /
      Last update: 2011-09-14 19:45    [W:0.020 / U:30.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site