lkml.org 
[lkml]   [2011]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Make PTRACE_SEIZE set ptrace options specified in 'data' parameter
On Sun, Sep 11, 2011 at 08:14:42PM +0200, Oleg Nesterov wrote:
> We need to rework the locking, yes. But we need the lock which protects
> the parent's list_head (currently we rely on tasklist). Yes, a single
> lock can't help. We already use ->cred_guard_mutex though.
>
> This needs more thinking, but imho child->siglock is pointless here.

But we can at least guarantee that if ->ptrace is set (or clear) while
tracee's siglock is held, its ->parent points to the tracer (or not).
At any rate, AFAICS, this currently doesn't really matter. I
suggested it mainly because it would make the locking change easier.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-09-13 10:03    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog