Messages in this thread | | | Date | Tue, 13 Sep 2011 16:46:53 +0900 | From | Tejun Heo <> | Subject | Re: [RFC]block: don't mark flush request as SOFTBARRIER |
| |
Hello, Shaohua.
On Tue, Sep 13, 2011 at 09:04:01AM +0800, Shaohua Li wrote: > we do the flush first and then dispatch the data. The flush is > already delayed a lot, so if latency is a problem, we already saw > it.
I don't necessarily agree with the above. We don't induce any extra latency for flushes which don't overlap.
> Why not just remove SOFTBARRIER and use elv_dispatch_sort() for > flush data so drive can better arrange requests?
Maybe, I don't know. Elevator sorting on writes is likely to be much less important to begin with. Combined with the fact that sorting flush data would require more writes to be flushed by the following flush, I don't think it would be clear which way would be better. If it can be shown that sorting flush data is better, why not?
Thanks.
-- tejun
| |