Messages in this thread | | | Date | Mon, 12 Sep 2011 19:23:37 -0700 (PDT) | From | Sage Weil <> | Subject | Re: [PATCH 1/2] ceph: fix parse options memory leak |
| |
Applied these both, thanks!
sage
On Mon, 12 Sep 2011, Noah Watkins wrote:
> ceph_destroy_options does not free opt->mon_addr that > is allocated in ceph_parse_options. > > Signed-off-by: Noah Watkins <noahwatkins@gmail.com> > --- > net/ceph/ceph_common.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c > index d4038ca..97f70e5 100644 > --- a/net/ceph/ceph_common.c > +++ b/net/ceph/ceph_common.c > @@ -232,6 +232,7 @@ void ceph_destroy_options(struct ceph_options *opt) > ceph_crypto_key_destroy(opt->key); > kfree(opt->key); > } > + kfree(opt->mon_addr); > kfree(opt); > } > EXPORT_SYMBOL(ceph_destroy_options); > -- > 1.7.6.1 > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
| |