lkml.org 
[lkml]   [2011]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v3 21/36] Hexagon: Add SMP support
    On Sun, Sep 11, 2011 at 11:51:52AM -0300, Benjamin Herrenschmidt wrote:
    > And on the producer side, a spinlock for one or... that looks like wheel
    > re-inventing to me :-)
    >
    > In fact your bit iteration loop also re-invents find_*_bit interfaces.
    >
    > Any reason why you don't simply use bitops or atomics here ?

    No particular reason; just the way it turned out when I was getting things
    working. I'll get them cleaned up.


    > Also what is your memory model ? ordered or weakly ordered ? Do you need
    > some kind of memory barrier between setting ipi->bits and
    > __vmintop_post() ?

    Our model is ordered, so there's no need for a barrier there yet.


    Thanks,
    Richard Kuo


    --

    Sent by an employee of the Qualcomm Innovation Center, Inc.
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


    \
     
     \ /
      Last update: 2011-09-13 01:41    [W:3.444 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site