Messages in this thread | | | Date | Mon, 12 Sep 2011 20:04:46 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 1/2] block: export __make_request |
| |
On 2011-09-12 15:38, Christoph Hellwig wrote: > On Mon, Sep 12, 2011 at 02:26:52PM +0200, Jens Axboe wrote: >>> What happens to the existing blk_make_request? >> >> I ended up naming __make_request() blk_queue_bio() instead. > > I really hate naming things different from the method they are > implementing. I've tried to figure out what the point of the > old blk_make_request is - why would we not go through > generic_make_request for this? > > Boaz, any idea?
I tend to agree, we could rename the existing blk_make_request(). It could be blk_make_request_from_bio() or something like that, since that's what it does.
-- Jens Axboe
| |