Messages in this thread |  | | Date | Mon, 12 Sep 2011 11:13:10 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 3/2] block: refactor generic_make_request |
| |
On Mon, Sep 12, 2011 at 11:09:35AM -0400, Vivek Goyal wrote: > On Mon, Sep 12, 2011 at 09:42:02AM -0400, Christoph Hellwig wrote: > > [..] > > + > > /* following loop may be a bit non-obvious, and so deserves some > > * explanation. > > * Before entering the loop, bio->bi_next is NULL (as all callers > > @@ -1557,16 +1561,15 @@ void generic_make_request(struct bio *bi > > * from the top. In this case we really did just take the bio > > * of the top of the list (no pretending) and so remove it from > > * bio_list, and call into __generic_make_request again. > ^^^^^^^^^^ > You got rid of __generic_make_request(). Now above comment has stale > reference to it.
Yeah, this should be ->make_request now.
|  |