lkml.org 
[lkml]   [2011]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/24] C6X: interrupt handling
On Mon, 12 Sep 2011, Mark Salter wrote:

> On Fri, 2011-09-09 at 16:33 +0200, Thomas Gleixner wrote:
> > On Wed, 31 Aug 2011, Mark Salter wrote:
> >
> > > + *
> > > + * Large parts taken directly from powerpc.
> >
> > Is it really necessary to copy that stuff instead of generalizing it ?
> > I guess that's mostly about the reverse map & Co.
>
> I have a patch that takes the code out of powerpc and puts in kernel/irq
> where both powerpc and c6x can use it. That leaves us with two files in
> kernel/irq trying to manage hw <--> virt mappings. So, some merging of
> irqdomain.c and the former powerpc code is needed. I'm not sure how that
> should go. At the moment, irqdomain doesn't support dynamic allocation
> of irq_descs, so its not currently suitable for powerpc or c6x.

Grant was working on that as well. You should talk to him.

>
> > > +/*
> > > + * IRQ controller and virtual interrupts
> > > + */
> >
> > How different is this from PPC ? Looks fairly familiar to me :)
>
> I had changed it in a few minor ways, but looking again, I probably
> didn't need to change it at all. In the patch to generalize it, I
> simply did s/NUM_ISA_INTERRUPTS/NR_IRQS_LEGACY/.

Thanks,

tglx


\
 
 \ /
  Last update: 2011-09-12 16:33    [W:0.061 / U:1.480 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site