lkml.org 
[lkml]   [2011]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch v3 14/36] Hexagon: Add signal functions
From
Date
On Thu, 2011-09-08 at 20:09 -0500, Richard Kuo wrote:

> +#define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
> +
> +struct sigframe {
> + unsigned long pad[2]; /* Used to be signal tramp */
> + struct sigcontext sc;
> + sigset_t mask;
> +};
> +
> +struct rt_sigframe {
> + unsigned long pad[2]; /* Used to be signal tramp */
> + struct siginfo info;
> + struct ucontext uc;
> +};

Why did you make two types of signal frames ? It's an unnecessary
complication... Dunno if you can still fix that (if you can still
control your ABI that is), but you should look how ppc64 uses the same
frame for RT and non-RT, avoids duplication of bugs :-)

Cheers,
Ben.




\
 
 \ /
  Last update: 2011-09-11 17:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog