Messages in this thread | | | Date | Sun, 11 Sep 2011 10:07:39 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static |
| |
On Fri, Sep 09, 2011 at 04:09:23PM -0700, H Hartley Sweeten wrote: > Local functions should be marked static. This quiets the following > sparse noise: > > warning: symbol 'lowmem_pfn_init' was not declared. Should it be static? > warning: symbol 'highmem_pfn_init' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers,com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: Yinghai Lu <yinghai@kernel.org> > Cc: Borislav Petkov <bp@alien8.de>
Looks good to me.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |