Messages in this thread | | | Subject | Re: [PATCH] treewide: Update sha_transform | From | Joe Perches <> | Date | Tue, 09 Aug 2011 17:57:28 -0700 |
| |
On Tue, 2011-08-09 at 08:41 -0700, Linus Torvalds wrote: > On Tue, Aug 9, 2011 at 1:58 AM, Joe Perches <joe@perches.com> wrote: > > Eliminate possible sha_transform unaligned accesses to data by copying > > data to an aligned __u32 array if necessary. > This is wrong. Not only does it double the stack space, when I tried > it for git it just made things slower. So don't do it.
Maybe the aligned copy should be in an #ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS block.
Maybe Mandeep could test aligned/unaligned speeds for his board?
| |