lkml.org 
[lkml]   [2011]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[slub p4 2/7] slub: Remove useless statements in __slab_alloc
    Two statements in __slab_alloc() do not have any effect.

    1. c->page is already set to NULL by deactivate_slab() called right before.

    2. gfpflags are masked in new_slab() before being passed to the page
    allocator. There is no need to mask gfpflags in __slab_alloc in particular
    since most frequent processing in __slab_alloc does not require the use of a
    gfpmask.

    Cc: torvalds@linux-foundation.org
    Signed-off-by: Christoph Lameter <cl@linux.com>

    ---
    mm/slub.c | 4 ----
    1 file changed, 4 deletions(-)

    Index: linux-2.6/mm/slub.c
    ===================================================================
    --- linux-2.6.orig/mm/slub.c 2011-08-01 11:03:15.000000000 -0500
    +++ linux-2.6/mm/slub.c 2011-08-01 11:04:06.385859038 -0500
    @@ -2064,9 +2064,6 @@ static void *__slab_alloc(struct kmem_ca
    c = this_cpu_ptr(s->cpu_slab);
    #endif

    - /* We handle __GFP_ZERO in the caller */
    - gfpflags &= ~__GFP_ZERO;
    -
    page = c->page;
    if (!page)
    goto new_slab;
    @@ -2163,7 +2160,6 @@ debug:

    c->freelist = get_freepointer(s, object);
    deactivate_slab(s, c);
    - c->page = NULL;
    c->node = NUMA_NO_NODE;
    local_irq_restore(flags);
    return object;


    \
     
     \ /
      Last update: 2011-08-09 23:17    [W:0.022 / U:30.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site