Messages in this thread | | | Subject | Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c | From | Joe Perches <> | Date | Tue, 09 Aug 2011 12:57:15 -0700 |
| |
On Tue, 2011-08-09 at 20:24 +0200, Eric Dumazet wrote: > Le mardi 09 août 2011 à 11:12 -0700, Joe Perches a écrit : > > On Tue, 2011-08-09 at 19:59 +0200, Eric Dumazet wrote: > > > Le mardi 09 août 2011 à 10:52 -0700, Joe Perches a écrit : > > > > On Tue, 2011-08-09 at 18:53 +0200, Eric Dumazet wrote: > > > > > Le mercredi 10 août 2011 à 00:39 +0800, stufever@gmail.com a écrit : > > > > [] > > > > > > + if (!local_rqfpr || !local_rqfcr) { > > > > > > + pr_err("Out of memory\n"); > > > > > Please remove this pr_err(), kmalloc() will complain already.
I think this is fine and should be kept until some general agreement is made that OOM messages should be removed generically.
If these are really superfluous, which I doubt a little because these are emitted at different KERN_<LEVEL>, (the generic one emits at KERN_WARNING), there are _thousands_ of these OOM errors in drivers/ alone that could be removed.
$ grep -rP --include=*.[ch] \ "(printk|\b[a-z]+_\w+)\s*\(.*\".*(alloc|mem)" drivers | \ wc -l 5147
call it 50% false positive, it's still a lot.
I think one more won't hurt for awhile.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |