Messages in this thread | | | Date | Tue, 09 Aug 2011 15:16:20 +0800 | From | Cong Wang <> | Subject | Re: [PATCH] nbd: some trivial improvements |
| |
于 2011年08月09日 01:20, Greg KH 写道: > On Mon, Aug 08, 2011 at 05:00:04PM +0800, Amerigo Wang wrote: >> This patch 1) uses task_pid_nr(current) to get the pid of current process, >> 2) replaces sysfs_create_file() with device_create_file(), 3) lower >> the loglevel of an error message. > > As you are doing 3 different things, please make this 3 different > patches (remember, one patch per logical thing being done.)
Since you insist, will do.
> >> >> if (max_part< 0) { >> - printk(KERN_CRIT "nbd: max_part must be>= 0\n"); >> + printk(KERN_ERR "nbd: max_part must be>= 0\n"); > > Again, dev_err() please. That properly identifies exactly which device > had problems. >
Ok, thanks for pointing this out! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |