Messages in this thread | | | Date | Tue, 9 Aug 2011 17:17:39 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/8] cgroups: Add res_counter_write_u64() API |
| |
On 07/29, Frederic Weisbecker wrote: > > +void res_counter_write_u64(struct res_counter *counter, int member, u64 val) > +{ > + unsigned long long *target; > + unsigned long flags; > + > + spin_lock_irqsave(&counter->lock, flags); > + target = res_counter_member(counter, member); > + *target = val; > + spin_unlock_irqrestore(&counter->lock, flags); > +}
Hmm. Why do we need counter->lock?
OK, probably it is for BITS_PER_LONG < 64. May be it makes sense to ifdef, just to make the code more understandable.
Oleg.
| |