lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 1/2] fuse: delete dead .write_begin and .write_end aops
Date
Christoph Hellwig <hch@infradead.org> writes:

> On Mon, Jul 25, 2011 at 10:35:34PM +0200, Johannes Weiner wrote:
>> Ever since 'ea9b990 fuse: implement perform_write', the .write_begin
>> and .write_end aops have been dead code.
>>
>> Their task - acquiring a page from the page cache, sending out a write
>> request and releasing the page again - is now done batch-wise to
>> maximize the number of pages send per userspace request.
>
> The loop code still calls them uncondtionally. This actually is a big
> as write_begin and write_end require filesystems specific locking,
> and might require code in the filesystem to e.g. update the ctime
> properly. I'll let Miklos chime in if leaving them in was intentional,
> and if it was a comment is probably justified.

Loop checks for ->write_begin() and falls back to ->write if the former
isn't defined.

So I think the patch is fine. I tested loop over fuse, and it still
works after the patch.

Added to for-next.

Thanks,
Miklos


\
 
 \ /
  Last update: 2011-08-08 17:07    [W:0.069 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site