Messages in this thread | | | Date | Sun, 7 Aug 2011 19:36:03 +0200 | Subject | Re: [PATCH] lib/sha1: use the git implementation of SHA-1 | From | Joachim Eastwood <> |
| |
On Sun, Aug 7, 2011 at 6:52 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Sun, Aug 7, 2011 at 4:54 AM, Joachim Eastwood <manabian@gmail.com> wrote: >> >> I see some ARM asm in your patch, maybe this is the cause? > > No, it's just a barrier to make sure the compiler doesn't do crazy > things, no actual asm instructions involved. > > That code is quite well tested in git, so I'm surprised it has any > problems on arm. It also has zero loops, a hang sounds odd. Can you > get some more debug information out of it (for example, where it hangs > - maybe "initcall_debug=1" on the kernel command line?
initcall_debug=1 didn't do anything to the boot log.
But I add some printk's around the calls to sha_init and sha_transform. ... NET: Registered protocol family 2 extract_buf: call sha_init extract_buf: call sha_init done extract_buf: call sha_transform extract_buf: call sha_transform done extract_buf: call sha_transform extract_buf: call sha_transform done extract_buf: function exit
These printk's come from drivers/char/random.c So it doesn't seem like it hangs in any of the sha_* funtions.
But I never see any of the printk's I added to net/ipv4/syncookies.c or net/ipv4/tcp_output.c.
btw, my compiler is: arm-angstrom-linux-gnueabi-gcc (GCC) 4.3.3
regards Joachim Eastwood
> The biggest difference with the git sources is the slightly different > calling conventions (passing the workspace array as an argument is bad > for code generation, btw - since now gcc doesn't see that the > workspace accesses are dead) and the fact that the kernel version uses > kernel macros like "get_unaligned_be32()" rather than it's own > implementation. > > Linus > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |