Messages in this thread | | | Date | Fri, 05 Aug 2011 16:02:58 +0800 | From | Cong Wang <> | Subject | Re: [PATCH -next] drivers/base/inode.c: let vmstat_text be optional |
| |
于 2011年08月05日 13:43, Randy Dunlap 写道: > On 08/04/11 19:38, Cong Wang wrote: >> 于 2011年08月05日 06:22, Randy Dunlap 写道: >>> From: Randy Dunlap<rdunlap@xenotime.net> >>> >>> vmstat_text is only available when PROC_FS or SYSFS is enabled. >>> This causes build errors in drivers/base/node.c when they are >>> both disabled: >>> >>> drivers/built-in.o: In function `node_read_vmstat': >>> node.c:(.text+0x10e28f): undefined reference to `vmstat_text' >>> >>> Rather than litter drivers/base/node.c with #ifdef/#endif around >>> the affected lines of code, add macros for optional sysdev >>> attributes so that those lines of code will be ignored, without >>> using #ifdef/#endif in the .c file(s). I.e., the ifdeffery >>> is done only in a header file with sysdev_create_file_optional() >>> and sysdev_remove_file_optional(). >>> >> >> This looks ugly for me, because other sysfs files here are not optional >> only due to that they don't rely on vmstat_text. >> >> I still think my approach to fix this is better, that is, introducing >> a new Kconfig for drivers/base/node.c which depends on CONFIG_SYSFS. > > Did you post a patch for that? I must have missed it.
Yes, see https://lkml.org/lkml/2011/7/19/31.
I think I need to resend it. :)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |