Messages in this thread Patch in this message | | | Date | Fri, 5 Aug 2011 21:43:57 +0800 | Subject | Re: [RFC patch] MIPS/netlogic: dont setup boot CPU twice | From | Hillf Danton <> |
| |
On Fri, Aug 5, 2011 at 2:51 AM, Jayachandran C. <jayachandranc@netlogicmicro.com> wrote: > The nlm_cpu_ready[] entry is not set for the boot_cpu, it is set for only > the secondary cpus in smpboot.S. The code works as it is, but your patch > makes it more explicit. > > My only commnet is that it might look better if you combine both the if checks. > Got and thanks. It is recooked as the following.
Hillf ------------------------------------------------------------------------------ Subject: [RFC patch] MIPS/netlogic: add comment for smp setup
It seems that BSP could be setup twice, but the nlm_cpu_ready array is only set for ASPs in smpboot.S, not including BSP.
Signed-off-by: Hillf Danton <dhillf@gmail.com> --- arch/mips/netlogic/xlr/smp.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/mips/netlogic/xlr/smp.c b/arch/mips/netlogic/xlr/smp.c index b495a7f..b82667c 100644 --- a/arch/mips/netlogic/xlr/smp.c +++ b/arch/mips/netlogic/xlr/smp.c @@ -167,6 +167,10 @@ void __init nlm_smp_setup(void)
num_cpus = 1; for (i = 0; i < NR_CPUS; i++) { + /* + * BSP is not set in nlm_cpu_ready array, it is only for + * ASPs (goto see smpboot.S) + */ if (nlm_cpu_ready[i]) { cpu_set(i, phys_cpu_present_map); __cpu_number_map[i] = num_cpus; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |