Messages in this thread | | | Date | Thu, 04 Aug 2011 12:48:31 +0300 | From | Dmitry Kasatkin <> | Subject | Re: [PATCH 1/1] xen: asm/io.h should not include xen.h if XEN is disabled |
| |
On 04/08/11 04:04, Linus Torvalds wrote: > On Wed, Aug 3, 2011 at 6:33 AM, Dmitry Kasatkin > <dmitry.kasatkin@intel.com> wrote: >> XEN related content is behind the CONFIG_XEN flag in the io.h. >> And <xen/xen.h> should be also behind CONFIG_XEN flag. > Wouldn't it be much nicer to just move the '#include <xen/xen.h>' line down? > It is probably a mater of taste.. to keep includes on the top. > Does the attached patch work for you? > Yes, it works... I experienced a problem in building some modules because of that include. In older kernel version (before .38 or so) everything was fine - it was not <xen/xen.h> includes in io.h
> Linus
Thank you..
| |