lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] regulator: 88pm8607: Fix off-by-one value range checking in the case of no id is matched
    From
    Date
    In the case of no id is matched, the variable i is equal to
    ARRAY_SIZE(pm8607_regulator_info).

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    I think compare variable i with ARRAY_SIZE(pm8607_regulator_info) here is slightly
    better in readability than compare with PM8607_ID_RG_MAX.
    Axel

    drivers/regulator/88pm8607.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
    index 5dcdb0f..ca0d608 100644
    --- a/drivers/regulator/88pm8607.c
    +++ b/drivers/regulator/88pm8607.c
    @@ -413,7 +413,7 @@ static int __devinit pm8607_regulator_probe(struct platform_device *pdev)
    if (info->desc.id == res->start)
    break;
    }
    - if ((i < 0) || (i > PM8607_ID_RG_MAX)) {
    + if (i == ARRAY_SIZE(pm8607_regulator_info)) {
    dev_err(&pdev->dev, "Failed to find regulator %llu\n",
    (unsigned long long)res->start);
    return -EINVAL;
    --
    1.7.4.1




    \
     
     \ /
      Last update: 2011-08-04 10:21    [W:3.870 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site