[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[RFC PATCH 0/3] If an IRQ is a GPIO, request and configure it
In, Mark Brown
pointed out that it was a little silly forcing every board or driver
to gpio_request() a GPIO that is later converted to an IRQ, and passed
to request_irq. The first patch in this series instead makes the core
IRQ code perform these calls when appropriate, to avoid duplicating it

However, this change has the potential for significant regressions; at
least some drivers are already calling gpio_request for GPIOs that are
also used as IRQs. This then causes the gpio_request inside the core IRQ
code to fail, which causes functional regressions. I'm not sure how wide-
spread this issue is, but in testing on NVIDIA Tegra, I found two
instances that needed to be fixed. Perhaps a failure of gpio_request
in the core IRQ code should trigger a WARN rather than returning an
error, to give a grace period for conversion of other code?

Stephen Warren (3):
irq: If an IRQ is a GPIO, request and configure it
mmc: tegra: Don't gpio_request GPIOs used as IRQs.
ASoC: jack_add_gpios: Don't gpio_request GPIOs used as IRQs.

drivers/mmc/host/sdhci-tegra.c | 8 --------
kernel/irq/manage.c | 25 +++++++++++++++++++++++--
sound/soc/soc-jack.c | 13 +------------
3 files changed, 24 insertions(+), 22 deletions(-)

 \ /
  Last update: 2011-08-05 01:03    [W:0.126 / U:0.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site