Messages in this thread | | | Date | Thu, 4 Aug 2011 23:46:54 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH 2/2] HID: kfree() NULL pointer cleanup |
| |
On Thu, 4 Aug 2011, Bojan Prtvar wrote:
> Checking for NULL pointers before kfree() is redundant. > > Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com> > --- > drivers/hid/hid-zydacron.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c > index e903715..1ad85f2 100644 > --- a/drivers/hid/hid-zydacron.c > +++ b/drivers/hid/hid-zydacron.c > @@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev) > struct zc_device *zc = hid_get_drvdata(hdev); > > hid_hw_stop(hdev); > - > - if (NULL != zc) > - kfree(zc); > + kfree(zc); > }
Applied, thanks.
-- Jiri Kosina SUSE Labs
| |