lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] HID: kfree() NULL pointer cleanup
On Thu, 4 Aug 2011, Bojan Prtvar wrote:

> Checking for NULL pointers before kfree() is redundant.
>
> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
> ---
> drivers/hid/hid-zydacron.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c
> index e903715..1ad85f2 100644
> --- a/drivers/hid/hid-zydacron.c
> +++ b/drivers/hid/hid-zydacron.c
> @@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev)
> struct zc_device *zc = hid_get_drvdata(hdev);
>
> hid_hw_stop(hdev);
> -
> - if (NULL != zc)
> - kfree(zc);
> + kfree(zc);
> }

Applied, thanks.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2011-08-04 23:49    [W:0.042 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site