lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: tps6586x: add SMx slew rate setting
On Thu, Aug 04, 2011 at 07:34:22PM +0800, dahuang@nvidia.com wrote:
> From: Danny Huang <dahuang@nvidia.com>
>
> Add output vlotage slew rate setting for SM0/SM1
>
> From: Xin Xie <xxie@nvidia.com>

Looks like you messed up here, I rather suspect Xin Xie rather than you
should be the author?

> +static int tps6586x_regulator_set_slew_rate(struct platform_device *pdev)
> +{
> + struct device *parent = pdev->dev.parent;
> + struct regulator_init_data *p = pdev->dev.platform_data;
> + struct tps6586x_settings *setting = p->driver_data;

If this is system configured data (which is what one would expect for
this) it should be coming in as platform data not driver data - what's
happened here?

> + default:
> + dev_err(&pdev->dev, "invalid regulator ID\n");
> + return -EINVAL;
> + }

Should say what data is invalid here, otherwise it's not going to be at
all obvious what's invalid.

> +enum {
> + TPS6586x_SLEW_RATE_INSTANTLY,
> + TPS6586x_SLEW_RATE_110UV,
> + TPS6586x_SLEW_RATE_220UV,
> + TPS6586x_SLEW_RATE_440UV,
> + TPS6586x_SLEW_RATE_880UV,
> + TPS6586x_SLEW_RATE_1760UV,
> + TPS6586x_SLEW_RATE_3520UV,
> + TPS6586x_SLEW_RATE_7040UV,
> +};

If the values are being written directly to the chip you should probably
explicitly specify the values that are being set.


\
 
 \ /
  Last update: 2011-08-04 14:41    [from the cache]
©2003-2011 Jasper Spaans