lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4/4] drivers/leds/leds-pca9532.c: delete useless initialization
Date
From: Julia Lawall <julia@diku.dk>

Delete nontrivial initialization that is immediately overwritten by the
result of an allocation function.

The semantic match that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
identifier i;
expression e;
@@

(
T i = \(0\|NULL\|ERR_PTR(...)\);
|
-T i = e;
+T i;
)
... when != i
i = \(kzalloc\|kcalloc\|kmalloc\)(...);

// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
drivers/leds/leds-pca9532.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -447,7 +447,7 @@ exit:
static int pca9532_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
- struct pca9532_data *data = i2c_get_clientdata(client);
+ struct pca9532_data *data;
struct pca9532_platform_data *pca9532_pdata = client->dev.platform_data;
int err;



\
 
 \ /
  Last update: 2011-08-04 12:33    [W:0.897 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site