[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 1/3] staging:iio:magnetometer:ak8975 Don't use irq_to_gpio()
    Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
    tegra_defconfig. This causes a build failure. Solve this with a heavy-handed
    method for now.

    I suspect the long-term solution is to pass both the IRQ and GPIO IDs
    to the driver; the GPIO ID coming from either platform data, or perhaps
    enhancing struct i2c_client to add a gpio field alongside irq.

    Signed-off-by: Stephen Warren <>
    Russell, now that irq_to_gpio() is going away, can you comment on how
    you'd like to fix drivers that do this kind of thing? Thanks.

    drivers/staging/iio/magnetometer/ak8975.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/staging/iio/magnetometer/ak8975.c b/drivers/staging/iio/magnetometer/ak8975.c
    index a17fa9f..bd40e32 100644
    --- a/drivers/staging/iio/magnetometer/ak8975.c
    +++ b/drivers/staging/iio/magnetometer/ak8975.c
    @@ -477,7 +477,7 @@ static int ak8975_probe(struct i2c_client *client,
    int err;

    /* Grab and set up the supplied GPIO. */
    - eoc_gpio = irq_to_gpio(client->irq);
    + eoc_gpio = -1; /* FIXME: irq_to_gpio(client->irq) */

    /* We may not have a GPIO based IRQ to scan, that is fine, we will
    poll if so */

     \ /
      Last update: 2011-08-31 21:43    [W:0.023 / U:160.688 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site