Messages in this thread | | | Date | Wed, 31 Aug 2011 14:21:29 +0200 | Subject | Re: [PATCH v2 0/6] perf: Intel uncore pmu counting support | From | Stephane Eranian <> |
| |
Hi,
So I finally got a bit of time to test the Ming's uncore PMU patch series on Intel NHM and SNB. I found several problems which I fixed and I also made some small improvements. With those fixes + improvements, the NHM/WSM patches look okay.
OTOH, the SNB patch needs more work. The SNB uncore PMU is more complicated than what the code supports today based on the info in Vol3b. For instance, SNB uncore events have constraints, therefore you need a proper scheduling function.
I will post my patch in separate email thread.
On Fri, Jul 15, 2011 at 4:34 PM, Lin Ming <ming.m.lin@intel.com> wrote: > Hi, all > > This is the v2 patches to support uncore pmu counting. > The most important change is to use hrtimer to pull uncore counters > to handle overflow, because uncore pmu interrupt does not work. > > v2 -> v1: > - Use hrtimer to pull counters > - Add interface to add general events to sysfs > - Move MSRs to msr-index.h > - Add uncore fixed counter > - Allow system-wide 'perf stat' without 'command' > > Comments are appreciated. > > Thanks, > Lin Ming > >
| |