Messages in this thread | | | From | Bryan Wu <> | Date | Wed, 31 Aug 2011 10:45:03 +0800 | Subject | Re: [PATCH] leds: kill CONFIG_LEDS_CLASS option |
| |
On Tue, Aug 30, 2011 at 5:34 AM, Richard Purdie <rpurdie@rpsys.net> wrote: > On Mon, 2011-08-29 at 16:34 -0400, Nicolas Pitre wrote: >> On Tue, 30 Aug 2011, Bryan Wu wrote: >> >> > Almost all the new leds driver and trigger driver are depends on >> > CONFIG_LED_CLASS, so there is no such user with CONFIG_NEW_LEDS=y >> > and CONFIG_LED_CLASS=n. Moreover, lots of API functions in led-class.c >> > are very common and should be built-in when CONFIG_NEW_LEDS=y. >> > >> > Obviously, CONFIG_LEDS_CLASS is pointless. This patch kills it and >> > also updates defconfigs which contains CONFIG_LEDS_CLASS. >> > >> > Signed-off-by: Bryan Wu <bryan.wu@canonical.com> >> > --- > > Looking at the code I'm a little concerned to see the direction this is > going. There was originally a reason that there were two options, it was > related to being able to compile as much of the LED code as a module as > possible. >
I quite understand the original reason for 2 options, but I failed to see any user of CONFIG_NEW_LEDS=y and CONFIG_LEDS_CLASS=n.
> It looks like commit 5ada28bf76752e33dce3d807bf0dfbe6d1b943ad changed > the tristate to a bool at which point the separate option obviously > becomes pointless. >
Exactly, this patch added some function API which are used very widely as default LEDS driver behavior in some drivers.
> Rather than accept the current direction and force everything builtin, > I'd much rather this code became modular capable again. There is no good > reason we should be forced to build everything into a kernel. >
OK, cool. I'd like to help and could you please also give some comments about my ledtrig-cpu driver in this patchset?
Thanks a lot, -- Bryan Wu <bryan.wu@canonical.com> Kernel Developer +86.138-1617-6545 Mobile Ubuntu Kernel Team Canonical Ltd. www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |