lkml.org 
[lkml]   [2011]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in connection.c
Date


> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Sunday, August 28, 2011 2:57 AM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 44/46] Staging: hv: vmbus: Fix checkpatch warnings in
> connection.c
>
> On Sat, 2011-08-27 at 11:31 -0700, K. Y. Srinivasan wrote:
> > Fix checkpatch warnings in connection.c.
> []
> > diff --git a/drivers/staging/hv/connection.c b/drivers/staging/hv/connection.c
> []
> > @@ -220,11 +220,11 @@ static void process_chn_event(u32 relid)
> > channel = relid2channel(relid);
> >
> > spin_lock_irqsave(&channel->inbound_lock, flags);
> > - if (channel && (channel->onchannel_callback != NULL)) {
> > + if (channel && (channel->onchannel_callback != NULL))
>
> Useless test for channel or bad placement for spin_lock.
> channel has already been dereferenced by the spin_lock.
>
>
Thanks Joe. I will fix this up.

Regards,

K. Y
\
 
 \ /
  Last update: 2011-08-30 19:07    [W:0.350 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site