lkml.org 
[lkml]   [2011]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging: vme: make match() driver specific to improve non-VME64x support
> Here there seems to be a missing kfree(vdev), like the one after device_unregister()
> a few lines earlier.

> > + if (!err & (drv->ndev == 0))
>
> Probably you meant if (!err && drv->ndev == 0) here.

Ah darn. Will fix and resend.

> In fact one could imagine a driver that has no devices when it's
> installed (it might get them later); so I'd remove this check.

Yeah I suppose with VME64x it's possible. Will remove.

--
/manohar


\
 
 \ /
  Last update: 2011-08-30 12:45    [from the cache]
©2003-2011 Jasper Spaans