lkml.org 
[lkml]   [2011]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 41/46] Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()
    > err3:
    > free_irq(irq, hv_acpi_dev);
    > err2:
    > bus_unregister(&hv_bus);
    > err1:
    > hv_cleanup();

    Also here is an oldbie trick. You could use multiples of ten like
    err30, err20, and err10. That way if you can add more error handling
    in the middle without changing the numbering. I knew my GW-BASIC
    experience would come in handy one day. :)

    The better way to label things is based on what happens when you get
    there: err_irq, err_unregister, err_cleanup.

    Some people label things based on where the goto is, but that breaks
    down if there is more than one goto. It doesn't really make sense to
    name the destination after the starting point.

    regards,
    dan carpenter


    \
     
     \ /
      Last update: 2011-08-30 12:35    [W:4.191 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site