Messages in this thread | | | Subject | Re: [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID | From | Vinod Koul <> | Date | Tue, 30 Aug 2011 15:32:02 +0530 |
| |
On Tue, 2011-08-30 at 09:54 +0200, Guennadi Liakhovetski wrote: > On Mon, 29 Aug 2011, Vinod Koul wrote: > > > >> You should not assign chan->private. > > > >> Please move this to dma_slave_control API > > > > > > > > I haven't seen any reply to this comment and this patch seems to still be > > > > outstanding, is there an updated version of this patch that I've missed? > > I don't recall seeing any updated version fixing this > > As a matter of fact, when you say "use dma_slave_control API," you > actually mean the dma_slave_config, right? Then, how is one supposed to > use it in this case? Shall we be issuing a DMA_SLAVE_CONFIG call inside of > the filter and check the return code? The problem is, that not all DMA > controllers on sh-mobile SoCs can service the same slave devices. So, if > we don't check in the filter we might well get an unsuitable DMA channel. Here you are assigning to chan->private your specific values, which should be moved to the dma_slave_config. But here you are removing the checks, and accepting the first channel you got, so how do you find channel is suitable or not.
-- ~Vinod
| |