lkml.org 
[lkml]   [2011]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/usb: Use kzalloc
Please add a Signed-off-by line as mentioned in
Documentation/SubmittingPatches.

Also you should Cc: the proper maintainer and list (in this case
netdev). You can use scripts/get_maintainers.pl to get this information

Cheers
Tobias

On 2011-08-02 at 18:09:28 +0200, Thomas Meyer <thomas@m3y3r.de> wrote:
> --- a/drivers/net/usb/cdc_ncm.c 2011-07-26 00:46:08.126846923 +0200
> +++ b/drivers/net/usb/cdc_ncm.c 2011-08-01 20:20:43.396390040 +0200
> @@ -479,12 +479,10 @@ static int cdc_ncm_bind(struct usbnet *d
> int temp;
> u8 iface_no;
>
> - ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
> + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> if (ctx == NULL)
> return -ENODEV;
>
> - memset(ctx, 0, sizeof(*ctx));
> -
> init_timer(&ctx->tx_timer);
> spin_lock_init(&ctx->mtx);
> ctx->netdev = dev->net;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


\
 
 \ /
  Last update: 2011-08-03 11:05    [W:0.059 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site