lkml.org 
[lkml]   [2011]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: loop device auto release patch
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    On 07/15/2011 03:19 PM, Andrew Morton wrote:
    > The patch appears to do two unrelated things. That's generally frowned
    > upon, but doesn't bother me much if the patch is small.
    >
    > Still, splitting it into two patches (in which the bugfix is staged
    > first) would be advantageous for people who might wish to backport the
    > fix into earlier kernels.

    It looks like this got stalled and someone emailed me asking what
    happened to it. I'm not sure that splitting the patch in two makes
    sense. I don't see how it does two unrelated things. The uevent
    problem was caused by the argument being NULL. This patch just removes
    the argument since it is entirely unnecessary. Given that the argument
    is gone and can no longer be passed as NULL, the tests for NULL are
    rendered moot, and so removing them seems quite related. I suppose you
    could do the first and not the second, but then you would be leaving
    cruft behind.
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.11 (GNU/Linux)
    Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

    iEYEARECAAYFAk45/MAACgkQJ4UciIs+XuL7+gCfUA8TpE2SRRCo+/VzRJMCrwg6
    OEsAmwWphcaIF/wdguyHch6gEizv1Tjb
    =pGGG
    -----END PGP SIGNATURE-----


    \
     
     \ /
      Last update: 2011-08-04 04:01    [W:3.471 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site