lkml.org 
[lkml]   [2011]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[082/102] n_gsm: fix the wrong FCS handling
    3.0-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: "Du, Alek" <alek.du@intel.com>

    commit f086ced17191fa0c5712539d2b680eae3dc972a1 upstream.

    FCS could be GSM0_SOF, so will break state machine...

    [This byte isn't quoted in any way so a SOF here doesn't imply an error
    occurred.]

    Signed-off-by: Alek Du <alek.du@intel.com>
    Signed-off-by: Alan Cox <alan@linux.intel.com>
    [Trivial but best backported once its in 3.1rc I think]
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/tty/n_gsm.c | 4 ----
    1 file changed, 4 deletions(-)

    --- a/drivers/tty/n_gsm.c
    +++ b/drivers/tty/n_gsm.c
    @@ -1823,10 +1823,6 @@ static void gsm0_receive(struct gsm_mux
    break;
    case GSM_FCS: /* FCS follows the packet */
    gsm->received_fcs = c;
    - if (c == GSM0_SOF) {
    - gsm->state = GSM_SEARCH;
    - break;
    - }
    gsm_queue(gsm);
    gsm->state = GSM_SSOF;
    break;



    \
     
     \ /
      Last update: 2011-08-04 01:39    [W:0.019 / U:121.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site