Messages in this thread | | | From | H Hartley Sweeten <> | Date | Wed, 3 Aug 2011 11:22:57 -0500 | Subject | RE: [RFC PATCH] watchdog: ep93xx: Use the WatchDog Timer Driver Core. |
| |
On Wednesday, August 03, 2011 1:16 AM, Mika Westerberg wrote: > On Tue, Aug 02, 2011 at 11:55:36AM -0500, H Hartley Sweeten wrote: >>>> -static const struct watchdog_info ident = { >>>> - .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE, >>>> - .identity = "EP93xx Watchdog", >>>> +static const struct watchdog_info ep93xx_wdt_ident = { >>>> + .options = WDIOF_CARDRESET | WDIOF_MAGICCLOSE, >>>> + .identity = "EP93xx Watchdog", >>>> }; > > One more thing I noticed: you should add WDIOF_KEEPALIVEPING to the options > field. Otherwise it doesn't support ioctl(..., WDIOC_KEEPALIVE) which was > supported in the original driver.
I noticed that yesterday. I'll fix it and repost the patch shortly.
Thanks, Hartley
| |