Messages in this thread | | | Date | Wed, 3 Aug 2011 07:38:43 +0200 (CEST) | From | Jesper Juhl <> | Subject | Re: [PATCH] jbd/jbd2: add pointer type conversion on void *arg from void * to journal_t * explicitly in kjournald/kjournald2 |
| |
On Wed, 3 Aug 2011, Li Zefan wrote:
> 09:58, Wang Sheng-Hui wrote: > > The patch is against 3.0 > > > > The arg of kjournald/kjournald2 is void *, and points to type > > journal_t. We should convert it to journal_t * explicitly in > > the kjournald/kjournald2 function body. > > > > Why? > > Implicit convertion from void * to foo * is ok. Did the compiler > complain about this to you? >
Not only is it perfectly OK to rely on the implicit conversion, a lot of work has gone into actively removing such unneeded explicit casts over the years, so let's not introduce new ones.
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |