lkml.org 
[lkml]   [2011]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 23/24] x25: Remove unnecessary OOM logging messages
    Date
    Removing unnecessary messages saves code and text.

    Site specific OOM messages are duplications of a generic MM
    out of memory message and aren't really useful, so just
    delete them.

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    net/x25/x25_dev.c | 10 ++++------
    1 files changed, 4 insertions(+), 6 deletions(-)

    diff --git a/net/x25/x25_dev.c b/net/x25/x25_dev.c
    index e547ca1..b77852f 100644
    --- a/net/x25/x25_dev.c
    +++ b/net/x25/x25_dev.c
    @@ -147,10 +147,10 @@ void x25_establish_link(struct x25_neigh *nb)

    switch (nb->dev->type) {
    case ARPHRD_X25:
    - if ((skb = alloc_skb(1, GFP_ATOMIC)) == NULL) {
    - printk(KERN_ERR "x25_dev: out of memory\n");
    + skb = alloc_skb(1, GFP_ATOMIC);
    + if (skb == NULL)
    return;
    - }
    +
    ptr = skb_put(skb, 1);
    *ptr = X25_IFACE_CONNECT;
    break;
    @@ -182,10 +182,8 @@ void x25_terminate_link(struct x25_neigh *nb)
    return;

    skb = alloc_skb(1, GFP_ATOMIC);
    - if (!skb) {
    - printk(KERN_ERR "x25_dev: out of memory\n");
    + if (!skb)
    return;
    - }

    ptr = skb_put(skb, 1);
    *ptr = X25_IFACE_DISCONNECT;
    --
    1.7.6.405.gc1be0


    \
     
     \ /
      Last update: 2011-08-29 23:25    [W:0.021 / U:0.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site