| Subject | Re: [PATCH 08/32] nohz: Move nohz load balancer selection into idle logic | From | Peter Zijlstra <> | Date | Mon, 29 Aug 2011 16:45:17 +0200 |
| |
On Mon, 2011-08-15 at 17:52 +0200, Frederic Weisbecker wrote: > We want the nohz load balancer to be an idle CPU, thus > move that selection to strict dyntick idle logic.
Again, the important part is missing, why is this correct?
I'm not at all convinced this is correct, suppose all your cpus (except the system CPU, which we'll assume has many tasks) are busy running 1 task. Then two of them get an extra task, now if those two happen to be SMT siblings you want the load-balancer to pull on task out from the SMT pair, however nobody is pulling since nobody is idle.
AFAICT this breaks stuff and the ILB needs some serious attention in order to fix this.
|