Messages in this thread | | | Date | Mon, 29 Aug 2011 19:52:09 +0530 | Subject | Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout | From | Jassi Brar <> |
| |
On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@ladisch.de> wrote:
>> > + buf, val_len, 1000) >= val_len) { >> > + buf, val_len, 1000) >= 0) { >> > + !value, 0, NULL, 0, 1000); >> > + !value, 0, NULL, 0, 1000); >> > + value, index + 2, NULL, 0, 1000); >> > + jacks[i].unitid << 8, buf, 3, 1000); >> > + 50, 0, &new_status, 1, 1000); >> >> How about also converting to use a local define for timeout value ? > > ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value, > we could just as well drop this parameter. Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!
| |